Skip to content

Add option to filter automodel queries#13852

Merged
starcke merged 3 commits into
mainfrom
starcke/automodel-package-filter
Aug 8, 2023
Merged

Add option to filter automodel queries#13852
starcke merged 3 commits into
mainfrom
starcke/automodel-package-filter

Conversation

@starcke

@starcke starcke commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

This is a first tak at how to add runtime filtering to the automodel candidate queries. I am not super up to speed in CodeQL so feedback is welcome.

This is used by the data extension as seen here: github/vscode-codeql#2670

@github-actions github-actions Bot added the Java label Jul 31, 2023
Comment thread java/ql/src/Telemetry/AutomodelJavaUtil.qll Fixed
@starcke starcke force-pushed the starcke/automodel-package-filter branch 2 times, most recently from 7aeae17 to 0c11668 Compare July 31, 2023 08:17
@aeisenberg

Copy link
Copy Markdown
Contributor

Looks reasonable to me.

@starcke starcke force-pushed the starcke/automodel-package-filter branch from decee7e to 504e614 Compare August 1, 2023 09:36
@starcke starcke changed the title Add option to filter automodel queries by package. Add option to filter automodel queries Aug 1, 2023
@starcke starcke force-pushed the starcke/automodel-package-filter branch from 504e614 to fc8c7c8 Compare August 2, 2023 07:29
@starcke starcke force-pushed the starcke/automodel-package-filter branch from fc8c7c8 to 131ae1a Compare August 3, 2023 07:54
@starcke starcke marked this pull request as ready for review August 3, 2023 09:41
@starcke starcke requested a review from a team as a code owner August 3, 2023 09:41
@starcke starcke requested a review from kaeluka August 3, 2023 09:42
@starcke starcke added the no-change-note-required This PR does not need a change note label Aug 3, 2023

@kaeluka kaeluka left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

@starcke starcke merged commit 7da6da1 into main Aug 8, 2023
@starcke starcke deleted the starcke/automodel-package-filter branch August 8, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Java no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants